fix: localize the Assets catalog list chrome - #80
Merged
Conversation
Move Assets list/toolbar copy into activity.catalog keys, reuse navigation.tabs for kinds, and keep Extra info inspector strings as-is.
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d2bd615. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Follow-up acotado del catálogo de Assets. No traduce el resto de la app ni el cuerpo de
VideoExtraInfoDialog. No reescribe el inspector Extra info.AssetsPanel) pasan a clavesactivity.catalog.*navigation.tabs.all/images/videos/audio/model3d/scenesy añadennavigation.tabs.documentscommon.actions.search/common.actions.reloadpara el nombre accesible; el placeholder y el tooltip siguen siendo copy de catálogoactivity.catalog.itemsAcrossLocations(plural) en vez de sobrecargarcommon.count.item_*activity.inspector.*,activity.extraInfo) se deja como estáZona migrada
Chrome de listado/toolbar del catálogo de Assets.
Deuda que permanece
Etiquetas de campos de
VideoExtraInfoDialog, resto de paneles. No se toca init i18n niresources.ts.Verificación local
npm run i18n:checknpm test(486)--max-warnings=0npx tsc -b --pretty falsePendiente de CI en GitHub.
No se han tocado launchers, WanGP, modelos ni
comunicaciones/.Note
Low Risk
UI-only string substitution with matching en/es keys and tests; no API, auth, or data-path changes.
Overview
Replaces hardcoded Spanish/English copy in
AssetsPanellist and toolbar with i18n keys so the Assets catalog follows the UI language.Catalog chrome now uses
activity.catalog.*for the item count (itemsAcrossLocationswith pluralization), search placeholder, kind/workspace filter labels, reload tooltip, load/error/empty states, and “Load more”. Kind filter options no longer use inline labels; they referencenavigation.tabs.*(including newtabs.documents) via typedlabelKeyentries. Search and reload buttons reusecommon.actions.searchandcommon.actions.reloadfor accessible names.Locale files add the
catalogblock in English and Spanishactivity.json, plusdocumentsundernavigation.tabs. Tests inassetsCatalog.test.mjsandi18nFoundation.test.tsxassert translation usage and block regressions to hardcoded catalog strings. The Extra info inspector and other panels are unchanged.Reviewed by Cursor Bugbot for commit d2bd615. Configure here.